Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use catalogRegion instead of region for filters #161

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

hiltol
Copy link
Collaborator

@hiltol hiltol commented Apr 15, 2024

No description provided.

@hiltol hiltol requested a review from luisarojas April 15, 2024 15:55
@luisarojas
Copy link
Collaborator

luisarojas commented Apr 15, 2024

Summary of changes (for our records, and my own understanding):

  • Replace current ‘region’ attribute filter with catalogRegion instead. This property has a more accurate values, especially in cases where the some region values are stored under a different name in the previous ‘region’ attribute used (e.g. eu-de showing as eu-central).
    • Tests have also been updated to use eu-de instead of us-south as input.
  • Add logic such that, if an entitlement is specified, then assume OCP licensing is already covered. Only use pricing that is not included in the OCP charges.

@hiltol hiltol merged commit 98c4434 into master Apr 15, 2024
6 of 7 checks passed
@hiltol hiltol deleted the fix/vpc-regions branch April 15, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants