Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new positional arg for class SQLQuery #65

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Adds new positional arg for class SQLQuery #65

merged 6 commits into from
Apr 30, 2020

Conversation

shawnzhu
Copy link
Contributor

Fixes #63

PS: it starts to use responses for testing requests.

@shawnzhu shawnzhu changed the title Adds new args for method submit_sql() Adds new positional arg for class SQLQuery Apr 30, 2020
@shawnzhu shawnzhu marked this pull request as ready for review April 30, 2020 17:10
@shawnzhu shawnzhu mentioned this pull request Apr 30, 2020
Closed
@shawnzhu shawnzhu requested a review from torsstei April 30, 2020 17:13
torsstei
torsstei approved these changes Apr 30, 2020
View reviewed changes
Copy link

@torsstei torsstei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks you @shawnzhu !

@torsstei torsstei merged commit 5cd7b2b into IBM-Cloud:master Apr 30, 2020
@shawnzhu shawnzhu mentioned this pull request Apr 30, 2020
Open
@shawnzhu shawnzhu deleted the 429 branch April 30, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torsstei torsstei torsstei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New feature: automatic wait and retry when hitting request rate limit
2 participants
@shawnzhu @torsstei