Test case config refactored

IBM-Cloud · Sep 9, 2022 · a0fd916 · a0fd916
1 parent 99896d6
commit a0fd916
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/ibm/service/power/resource_ibm_pi_volume_test.go b/ibm/service/power/resource_ibm_pi_volume_test.go
@@ -197,27 +197,22 @@ func TestAccIBMPIVolumeGRS(t *testing.T) {
 }
 
 func testAccCheckIBMPIVolumeGRSConfig(name string) string {
-	return fmt.Sprintf(`
-	resource "ibm_pi_volume" "power_volume"{
-		pi_volume_size       = 20
-		pi_volume_name       = "%[1]s"
-		pi_volume_pool       = "%[3]s"
-		pi_volume_shareable  = true
-		pi_cloud_instance_id = "%[2]s"
-		pi_replication_enabled = true
-	  }
-	`, name, acc.Pi_cloud_instance_id, acc.PiStoragePool)
+	return testAccCheckIBMPIVolumeGRSBasicConfig(name, acc.Pi_cloud_instance_id, acc.PiStoragePool, true)
 }
 
 func testAccCheckIBMPIVolumeGRSUpdateConfig(name string) string {
+	return testAccCheckIBMPIVolumeGRSBasicConfig(name, acc.Pi_cloud_instance_id, acc.PiStoragePool, false)
+}
+
+func testAccCheckIBMPIVolumeGRSBasicConfig(name, piCloudInstanceId, piStoragePool string, replicationEnabled bool) string {
 	return fmt.Sprintf(`
 	resource "ibm_pi_volume" "power_volume"{
 		pi_volume_size       = 20
 		pi_volume_name       = "%[1]s"
 		pi_volume_pool       = "%[3]s"
 		pi_volume_shareable  = true
 		pi_cloud_instance_id = "%[2]s"
-		pi_replication_enabled = false
+		pi_replication_enabled = %[4]v
 	  }
-	`, name, acc.Pi_cloud_instance_id, acc.PiStoragePool)
+	`, name, piCloudInstanceId, piStoragePool, replicationEnabled)
 }