ibm_pi_instance not failing on ERROR state

[yussufsh]

Terraform continue to create instance for 2 hours even when GUI shows instance in ERROR state.

Also, the instance create timeout value should be customizable.

Terraform Version

terraform version

Terraform v0.13.2

• provider registry.terraform.io/ibm-cloud/ibm v1.11.2

Affected Resource(s)

Please list the resources as a list, for example:

• ibm_pi_instance

Expected Behavior

ibm_pi_instance should exit with error if instance status is ERROR.

Actual Behavior

ibm_pi_instance continously wait for Available, OK state till timeout.

Important Factoids

There was some maintanance at the CoLo side which turned the instance into ERROR state.

[yussufsh]

@bpradipt

[surajsub]

Also please note that this is not a terraform issue. This is a power / cloud colo issue.

[bpradipt]

Also please note that this is not a terraform issue. This is a power / cloud colo issue.

Yes true, it's not a TF issue. It's a colo issue and there could be other such cases where instances errors out as we are seeing.
Providing some flexibility in the provider to fail fast will help the end user experience.

[hkantare]

Like other resources (VPC instances, soon ) we need to add Target for even Error or failed state

terraform-provider-ibm/ibm/resource_ibm_is_instance.go

Line 839 in f2b3d7f

Target: []string{isInstanceStatusRunning, "available", "failed", ""},

and come out from the wait logic

[hkantare]

terraform-provider-ibm/ibm/resource_ibm_pi_instance.go

Line 765 in f2b3d7f

Target: []string{"OK", "ACTIVE", helpers.PIInstanceHealthOk},

Add the keyword for failed or error based on the API response (keyword for error)

[surajsub]

I spoke to the power team. they did provide me with some input. I will submit another PR