Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS Instance Policies not setting key_create_import_access values correctly #4340

Closed
MatthewLemmond opened this issue Feb 9, 2023 · 9 comments
Labels
service/Key Management Services Issues related to Key Management Release service/Resource Management Issues related to Resource Manager or Resource controller Issues

Comments

@MatthewLemmond
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform IBM Provider Version

Terraform v1.3.7
on darwin_amd64

  • provider registry.terraform.io/ibm-cloud/ibm v1.50.0

Affected Resource(s)

  • ibm_kms_instance_policies

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "ibm_resource_group" "resource_group" {
  name = "tmp-resource-group"
}

resource "ibm_resource_instance" "key_protect_instance" {
  name              = "tmp-kp"
  resource_group_id = ibm_resource_group.resource_group.id
  service           = "kms"
  plan              = "tiered-pricing"
  location          = "eu-gb"
  service_endpoints = "public-and-private"
}

resource "ibm_kms_instance_policies" "key_protect_instance_policies" {
  instance_id = ibm_resource_instance.key_protect_instance.guid
  key_create_import_access {
    enabled             = true
    create_root_key     = true
    create_standard_key = false
    import_root_key     = true
    import_standard_key = false
    enforce_token       = false
  }
}

Debug Output

https://gist.github.com/MatthewLemmond/c9b8d469fb807cfba51293e97eb3d880

Panic Output

N/A

Expected Behavior

Expected the call to set the instance policy for key create import access according to the values passed in.

Actual Behavior

Values for the key create import access policy were set to their defaults.

Steps to Reproduce

  1. tf apply

Important Factoids

References

  • #0000
@ocofaigh
Copy link
Contributor

@hkantare Any idea who could look into this?

@hkantare
Copy link
Collaborator

@ocofaigh The people for KMS team can look into this
@dinesh-venkatraman (dinesh.venkatraman@in.ibm.com)
Harshit Gupta (harshit.gupta2@ibm.com)

@hkantare
Copy link
Collaborator

@ocofaigh The support for KMS is now handled by KMS team (US team)
Bruno Henriques (bruno.henriques@ibm.com) can you please take this issue with the team?

@ocofaigh
Copy link
Contributor

Thanks, I have reached out to Bruno

BrunoHenriques added a commit to BrunoHenriques/terraform-provider-ibm that referenced this issue Apr 2, 2023
Uptake version v0.10.0 of Key Protect Go SDK which contains [the base fix](IBM/keyprotect-go-client#107) for [KMS Instance Policies not setting key_create_import_access values correctly IBM-Cloud#4340](IBM-Cloud#4340)
@BrunoHenriques
Copy link
Contributor

BrunoHenriques commented Apr 2, 2023

PR with the fix at #4467

hkantare pushed a commit that referenced this issue Apr 14, 2023
)

* Uptake version v0.10.0 of Key Protect Go SDK

Uptake version v0.10.0 of Key Protect Go SDK which contains [the base fix](IBM/keyprotect-go-client#107) for [KMS Instance Policies not setting key_create_import_access values correctly #4340](#4340)

* Update go.sum
@ocofaigh
Copy link
Contributor

ocofaigh commented May 8, 2023

@BrunoHenriques If this is now fixed, can you confirm which version of the provider and perhaps close the issue?

@BrunoHenriques
Copy link
Contributor

@BrunoHenriques If this is now fixed, can you confirm which version of the provider and perhaps close the issue?

@ocofaigh

Fixed as part of IBM-Cloud/terraform-provider v1.53.0
See https://github.com/IBM-Cloud/terraform-provider-ibm/releases/tag/v1.53.0.

@BrunoHenriques
Copy link
Contributor

@MatthewLemmond Please verify the fix using IBM-Cloud/terraform-provider v1.53.0 can close the issue. Thank you.

@MatthewLemmond
Copy link
Author

Confirmed, this issue is now resolved, closing this out

omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this issue Jul 20, 2023
…o SDK (IBM-Cloud#4467)

* Uptake version v0.10.0 of Key Protect Go SDK

Uptake version v0.10.0 of Key Protect Go SDK which contains [the base fix](IBM/keyprotect-go-client#107) for [KMS Instance Policies not setting key_create_import_access values correctly IBM-Cloud#4340](IBM-Cloud#4340)

* Update go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Key Management Services Issues related to Key Management Release service/Resource Management Issues related to Resource Manager or Resource controller Issues
Projects
None yet
Development

No branches or pull requests

4 participants