While creating a DL Connect gateway do not wait for gateway to be provisioned for few providers #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Apr 2, 2021
| @@ -541,10 +542,20 @@ func resourceIBMdlGatewayCreate(d *schema.ResourceData, meta interface{}) error | |||
|
|
|||
| log.Printf("[INFO] Created Direct Link Gateway (%s Template) : %s", dtype, *gateway.ID) | |||
| if dtype == "connect" { | |||
| _, err = isWaitForDirectLinkAvailable(directLink, d.Id(), d.Timeout(schema.TimeoutCreate)) | |||
| getPortOptions := directLink.NewGetPortOptions(*gateway.Port.ID) | |||
| port, response, err := directLink.GetPort(getPortOptions) | |||
| if err != nil { | |||
There was a problem hiding this comment.
if err != nil || response != nil || port != nil
so that we are safe to handle the condition if port is nil by any chance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DL Connect gateway is created we wait for the gateway to be moved to provisioned state. But for few providers we shall not wait for the gateway to be provisioned.
So we will check the provider to which the port, that is being used to create a connect gateway, belongs and if it matches those providers we will not wait for the gateway to be provisioned.