Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Detach targets before deleting security group #2723

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Bugfix: Detach targets before deleting security group #2723

merged 1 commit into from
Jul 5, 2021

Conversation

SunithaGudisagarIBM
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-17041

Output from acceptance testing:
Screenshot 2021-06-09 at 1 35 40 PM
Screenshot 2021-06-09 at 2 01 41 PM

$ make testacc TEST=./ibm TESTARGS='-run=TestAccIBMISSecurityGroup_basic'

hkantare
hkantare reviewed Jun 18, 2021
View reviewed changes
ibm/resource_ibm_is_security_group.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_security_group.go Show resolved Hide resolved
ibm/resource_ibm_is_security_group.go Show resolved Hide resolved
@SunithaGudisagarIBM
Copy link
Collaborator Author

Screenshot 2021-06-22 at 5 03 06 PM

@hkantare hkantare merged commit 868a77a into IBM-Cloud:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunithaGudisagarIBM @hkantare @SunithaGudisagarIBM1