Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a vpcid filter on listing sg on resource_is_vpc read #2978

Merged
merged 1 commit into from
Aug 13, 2021
Merged

added a vpcid filter on listing sg on resource_is_vpc read #2978

merged 1 commit into from
Aug 13, 2021

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Aug 12, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #2982

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

astha-jain
astha-jain approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good.

@hkantare hkantare merged commit 9a47d83 into IBM-Cloud:master Aug 13, 2021
@ujjwal-ibm ujjwal-ibm deleted the bug-vpc-list-sg-based-on-vpc branch October 12, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astha-jain astha-jain astha-jain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable filter for security group by VPC
3 participants
@ujjwal-ibm @astha-jain @hkantare