Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for vSCSI pi_instance deployment #3070

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Add support for vSCSI pi_instance deployment #3070

merged 2 commits into from
Sep 6, 2021

Conversation

yussufsh
Copy link
Collaborator

@yussufsh yussufsh commented Sep 6, 2021

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@yussufsh
Add support for vSCSI pi_instance deployment
ca8d417 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Copy link
Collaborator Author

yussufsh commented Sep 6, 2021

cc @hkantare

@yussufsh
Added ValidateFunc for pi_storage_connection
91bec6d 
Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@hkantare hkantare merged commit e809d8b into IBM-Cloud:master Sep 6, 2021
@yussufsh
Copy link
Collaborator Author

yussufsh commented Sep 6, 2021

Thanks @hkantare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yussufsh @hkantare