Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented feature to edit BGP IPs and ASN values for non provider and provider flow gateways. #3186

Merged
merged 7 commits into from
Oct 13, 2021

Conversation

purandarrao
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TEST=./ibm TESTARGS='-run=TestAccIBMDLProviderGateway_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm -v -run=TestAccIBMDLProviderGateway_basic -timeout 700m
…
…
=== RUN   TestAccIBMDLProviderGateway_basic
--- PASS: TestAccIBMDLProviderGateway_basic (65.29s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 66.744s
$ make testacc TEST=./ibm TESTARGS='-run=TestAccIBMDLGateway_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm -v -run=TestAccIBMDLGateway_basic -timeout 700m
…
…
=== RUN   TestAccIBMDLGateway_basic
--- PASS: TestAccIBMDLGateway_basic (139.51s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 141.232s

@hkantare
Copy link
Collaborator

Please resolve the conflicts in go.mod and update the documentation with new attributes and removing force new on the attributes which supports update

@purandarrao
Copy link
Contributor Author

purandarrao commented Oct 11, 2021

Please resolve the conflicts in go.mod and update the documentation with new attributes and removing force new on the attributes which supports update

@hkantare Thanks. Resolved conflicts and I've removed force new property. We don't need any documentation change, since all the 3 fields are that are supported for update are already existing fields.

@hkantare
Copy link
Collaborator

hkantare commented Oct 12, 2021

And in docs need to remove the property (Force new resource) since now update is supported
Screenshot 2021-10-12 at 10 03 38 AM
For all the changes

@hkantare hkantare merged commit bc36fbe into IBM-Cloud:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants