Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VTL #3328

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Add support for VTL #3328

merged 4 commits into from
Dec 2, 2021

Conversation

ChaseRun
Copy link
Collaborator

Signed-off-by: Chase Austin chase@ibm.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (1032.71s)
PASS
=== RUN   TestAccIBMPIInstanceNetwork
--- PASS: TestAccIBMPIInstanceNetwork (1001.32s)
PASS
=== RUN   TestAccIBMPIInstanceVTL
--- PASS: TestAccIBMPIInstanceVTL (754.28s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceBasic
--- PASS: TestAccIBMPICatalogImagesDataSourceBasic (11.74s)
PASS
=== RUN   TestAccIBMPICatalogImagesDataSourceSAP
--- PASS: TestAccIBMPICatalogImagesDataSourceSAP (10.89s)
PASS
=== RUN   TestAccIBMPICatalogImagesDataSourceVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceVTL (10.40s)
PASS
=== RUN   TestAccIBMPICatalogImagesDataSourceSAPAndVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceSAPAndVTL (10.40s)
PASS
...

Add support for VTL: pi_instance and pi_image
fce830c 
Signed-off-by: Chase Austin [chase@ibm.com](mailto:chase@ibm.com)

* Please vote on this pull request by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original pull request comment to help the community and maintainers prioritize this request
* Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:
```
=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (1032.71s)
PASS
=== RUN   TestAccIBMPIInstanceNetwork
--- PASS: TestAccIBMPIInstanceNetwork (1001.32s)
PASS
=== RUN   TestAccIBMPIInstanceVTL
--- PASS: TestAccIBMPIInstanceVTL (754.28s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceBasic
--- PASS: TestAccIBMPICatalogImagesDataSourceBasic (11.74s)
PASS
=== RUN   TestAccIBMPICatalogImagesDataSourceSAP
--- PASS: TestAccIBMPICatalogImagesDataSourceSAP (10.89s)
PASS
=== RUN   TestAccIBMPICatalogImagesDataSourceVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceVTL (10.40s)
PASS
=== RUN   TestAccIBMPICatalogImagesDataSourceSAPAndVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceSAPAndVTL (10.40s)
PASS
...
```
@ChaseRun
Copy link
Collaborator Author

ChaseRun commented Nov 12, 2021 •
edited
Loading

Resources

  • ibm_pi_image

    • Using new const name for pi_image_id

  • ibm_pi_instance

    • Added pi_license_repository_capacity ARGUMENT
    • Added license_repository_capacity ATTRIBUTE
    • Using new const name for pi_image_id
    • Modified log statement
    • Updated docs
    • Updated tests

DataSources

  • ibm_pi_catalog_images

    • Added vtl ARGUMENT
    • Using new implementation of GetAllStockImages()
    • Updated docs
    • Updated tests

  • ibm_pi_image

    • Added image_type ATTRIBUTE
    • Updated docs

  • ibm_pi_images

    • Removed pi_image_name ARGUMENT
    • Added image_type ATTRIBUTE
    • Updated docs

  • ibm_pi_instance

    • Added license_repository_capacity ATTRIBUTE
    • Updated docs

@ChaseRun ChaseRun closed this Nov 12, 2021
@ChaseRun ChaseRun reopened this Nov 12, 2021
@ChaseRun ChaseRun changed the title Add support for VTL: pi_instance and pi_image Add support for VTL Nov 12, 2021
yussufsh
yussufsh requested changes Nov 15, 2021
View reviewed changes
ibm/data_source_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/resource_ibm_pi_instance.go Show resolved Hide resolved
ibm/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Nov 15, 2021
@ChaseRun ChaseRun requested a review from yussufsh November 15, 2021 16:27
yussufsh
yussufsh requested changes Nov 19, 2021
View reviewed changes
website/docs/r/pi_instance.html.markdown Outdated Show resolved Hide resolved
ibm/data_source_ibm_pi_instance.go Show resolved Hide resolved
@ChaseRun ChaseRun requested a review from yussufsh November 29, 2021 15:18
yussufsh
yussufsh approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yussufsh yussufsh requested a review from hkantare November 29, 2021 16:17
@hkantare hkantare merged commit 52b2ef3 into IBM-Cloud:master Dec 2, 2021
@ChaseRun ChaseRun deleted the vtl branch February 15, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoralesjr rmoralesjr rmoralesjr approved these changes

@hkantare hkantare hkantare approved these changes

@yussufsh yussufsh yussufsh approved these changes

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChaseRun @yussufsh @hkantare @rmoralesjr