Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(is_instance): resize boot volume #3629

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Mar 2, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #2205

Output from acceptance testing:

--- PASS: TestAccIBMISInstance_ResizeBoot (269.09s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc	271.042s
--- PASS: TestAccIBMISInstance_basicwithipv4 (195.62s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     691.706s
--- PASS: TestAccIBMISInstanceSnapshotRestore_basic (580.66s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     582.528s
--- PASS: TestAccIBMISInstanceBandwidth_basic (296.80s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     298.455s
--- PASS: TestAccIBMISInstance_action (458.99s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     460.413s

@ujjwal-ibm ujjwal-ibm marked this pull request as draft March 3, 2022 08:59
@ujjwal-ibm ujjwal-ibm marked this pull request as ready for review March 3, 2022 10:23
@astha-jain
Copy link
Contributor

Looks good. @hkantare Please take a look.

@hkantare
Copy link
Collaborator

@ujjwal-ibm PR looks fine but can we test one scenario
Provision the resource using old binary 1.39.1 something and then use the new binary and compare the plan . It should n't have any diff

@ujjwal-ibm
Copy link
Collaborator Author

@hkantare
tested the scenario, it shows no change, just an addition of computed volume_id attribute

      ~ boot_volume {
            name       = "divot-track-majority-trespass"
          + volume_id  = "r010--aa51-408e-8b20-9ad0912a3a62"
            # (4 unchanged attributes hidden)
        }


No changes. Your infrastructure matches the configuration.

@hkantare hkantare merged commit e48332f into IBM-Cloud:master Mar 14, 2022
@ujjwal-ibm ujjwal-ibm deleted the resize-boot branch March 14, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boot_volume: size does not work on gen2
3 participants