Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCC-PostureManagement Create scope issue #3708

Merged
merged 10 commits into from
Apr 14, 2022

Conversation

sugatamazumdar
Copy link
Contributor

Create scope issue

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

sugatamazumdar and others added 9 commits April 4, 2022 20:31
Collector ID issue in resourceIBMSccPostureCollectorsRead and Account Id issue
Account Id issue from client session and not env var.
Account Id issue from client session and not env var.
Cred ID issue in resourceIBMSccPostureCredentialsRead and Account Id issue
Account Id issue from client session and not env var.
Scope ID issue in resourceIBMSccPostureScopesRead and Account Id issue
@hkantare
Copy link
Collaborator

Please share the testcase results of all the files chaned

@sugatamazumdar
Copy link
Contributor Author

@hkantare I am unable to send the logs in PR I will send over slack.

@sugatamazumdar
Copy link
Contributor Author

sugatamazumdar commented Apr 12, 2022

--- PASS: TestAccIBMSccPostureCollectorsBasic (36.50s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/scc 37.640s

--- PASS: TestAccIBMSccPostureCredentialsBasic (36.76s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/scc 37.797s

--- PASS: TestAccIBMSccPostureScopesBasic (56.72s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/scc 57.695s

@hkantare hkantare merged commit 25d24bf into IBM-Cloud:master Apr 14, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* SCC-PostureManagement Create scope issue

Create scope issue

* SCC-PostureManagement Collector ID, Account ID fix

Collector ID issue in resourceIBMSccPostureCollectorsRead and Account Id issue

* SCC-PostureManagement Account ID fix 

Account Id issue from client session and not env var.

* SCC-PostureManagement Account ID fix

Account Id issue from client session and not env var.

* SCC-PostureManagement Cred ID, Account ID fix

Cred ID issue in resourceIBMSccPostureCredentialsRead and Account Id issue

* SCC-PostureManagement Account ID fix

Account Id issue from client session and not env var.

* SCC-PostureManagement Scope ID, Account ID fix

Scope ID issue in resourceIBMSccPostureScopesRead and Account Id issue

* Add format code

* Fixes for id field

Co-authored-by: Sugata Mazumdar <Sugata.Mazumdar1@ibm.com>
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* SCC-PostureManagement Create scope issue

Create scope issue

* SCC-PostureManagement Collector ID, Account ID fix

Collector ID issue in resourceIBMSccPostureCollectorsRead and Account Id issue

* SCC-PostureManagement Account ID fix 

Account Id issue from client session and not env var.

* SCC-PostureManagement Account ID fix

Account Id issue from client session and not env var.

* SCC-PostureManagement Cred ID, Account ID fix

Cred ID issue in resourceIBMSccPostureCredentialsRead and Account Id issue

* SCC-PostureManagement Account ID fix

Account Id issue from client session and not env var.

* SCC-PostureManagement Scope ID, Account ID fix

Scope ID issue in resourceIBMSccPostureScopesRead and Account Id issue

* Add format code

* Fixes for id field

Co-authored-by: Sugata Mazumdar <Sugata.Mazumdar1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants