Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot volume encryption in cluster and workerpool #3776

Merged
merged 6 commits into from
May 25, 2022

Conversation

attilatabori
Copy link
Contributor

added kms_instance_id and crk to vpc cluster, vpc workerpool resources and to vpc workerpool datasource, for boot volume encryption

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

tabori@Attilas-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar -timeout 700m
[WARN] Set the environment variable IBM_APPID_TENANT_ID for testing AppID resources, AppID tests will fail if this is not set
[... cut the envvar warnings]
[INFO] Set the environment variable IBM_CONTAINER_CLUSTER_NAME for ibm_container_nlb_dns resource or datasource else tests will fail if this is not set correctly
=== RUN   TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar
--- PASS: TestAccIBMContainerVPCClusterWorkerPoolDataSourceEnvvar (627.15s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      628.366s



tabori@Attilas-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterEnvvar'                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVpcClusterEnvvar -timeout 700m
[WARN] Set the environment variable IBM_APPID_TENANT_ID for testing AppID resources, AppID tests will fail if this is not set
[... cut the envvar warnings]
[INFO] Set the environment variable IBM_CONTAINER_CLUSTER_NAME for ibm_container_nlb_dns resource or datasource else tests will fail if this is not set correctly
=== RUN   TestAccIBMContainerVpcClusterEnvvar

        resource "ibm_container_vpc_cluster" "cluster" {
                name              = "<redacted>"
                vpc_id            = "<redacted>"
                flavor            = "bx2.4x16"
                worker_count      = 1
                resource_group_id = "<redacted>"
                zones {
                        subnet_id = "<redacted>"
                        name      = "us-south-1"
                }
                kms_instance_id = "<redacted>"
                crk = "<redacted>"
        }

--- PASS: TestAccIBMContainerVpcClusterEnvvar (2048.25s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2049.277s


tabori@Attilas-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterWorkerPoolEnvvar'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVpcClusterWorkerPoolEnvvar -timeout 700m
[WARN] Set the environment variable IBM_APPID_TENANT_ID for testing AppID resources, AppID tests will fail if this is not set
[... cut the envvar warnings]
[INFO] Set the environment variable IBM_CONTAINER_CLUSTER_NAME for ibm_container_nlb_dns resource or datasource else tests will fail if this is not set correctly
=== RUN   TestAccIBMContainerVpcClusterWorkerPoolEnvvar
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolEnvvar (675.48s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      676.327s


...

…s and to vpc workerpool datasource, for boot volume encryption
@hkantare hkantare merged commit 841ca30 into IBM-Cloud:master May 25, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* added kms_instance_id and crk to vpc cluster, vpc workerpool resources and to vpc workerpool datasource, for boot volume encryption

* resolving review comments

* updates

* removed verifyignore of crk and kms in test, format update in reousrce

* format worker pool example
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* added kms_instance_id and crk to vpc cluster, vpc workerpool resources and to vpc workerpool datasource, for boot volume encryption

* resolving review comments

* updates

* removed verifyignore of crk and kms in test, format update in reousrce

* format worker pool example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants