IBM Cloud Databases - Deprecate flat list of scaling attributes #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maraibrahim/terraform-provider-ibm into deprecate_flat_list_attributes
omaraibrahim
changed the title
obai-1
reviewed
May 16, 2022
Comment on lines
+39
to
+45
| memory { | ||
| allocation_mb = 14336 | ||
| } | ||
|
|
||
| disk { | ||
| allocation_mb = 20480 | ||
| } |
There was a problem hiding this comment.
We should make sure these allocations are same as the "Small" T-Shirt sizes.
It will be different for each database type.
obai-1
changed the title
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
…Cloud#3782) * added deprecation and updated docs * updated allocation sizes to be in accordance to "small" template sizes
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
…Cloud#3782) * added deprecation and updated docs * updated allocation sizes to be in accordance to "small" template sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the
ibm_databasegroups api the following attributes are set of deprecation:A deprecation attribute has been added and these attributes conflict with the groups attribute (that particular set of code was added in the groups PR). Also the docs have been updated.
Output from acceptance testing: