Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3803 set roles in resource_key #3810

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Conversation

kavya498
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #3803

@hkantare
Copy link
Collaborator

hkantare commented Jun 6, 2022

Can you add testcase results

@kavya498
Copy link
Collaborator Author

kavya498 commented Jun 7, 2022

Test results

=== RUN   TestAccIBMResourceKeyDataSource_basic
--- PASS: TestAccIBMResourceKeyDataSource_basic (111.11s)
=== RUN   TestAccIBMResourceKeyDataSource_mostrecent
--- PASS: TestAccIBMResourceKeyDataSource_mostrecent (82.82s)
=== RUN   TestAccIBMResourceKey_Basic
--- PASS: TestAccIBMResourceKey_Basic (85.08s)
=== RUN   TestAccIBMResourceKey_With_Tags
--- PASS: TestAccIBMResourceKey_With_Tags (93.95s)
=== RUN   TestAccIBMResourceKey_Parameters
--- PASS: TestAccIBMResourceKey_Parameters (71.09s)
=== RUN   TestAccIBMResourceKey_WithCustomRole
--- PASS: TestAccIBMResourceKey_WithCustomRole (66.32s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/resourcecontroller	511.313s

@hkantare hkantare merged commit 4f3885c into IBM-Cloud:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource: ibm_resource_key is always recreated even when no changes are available for service Role
2 participants