Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ibm_is_instance) : fixed force new on change in snapshot in boot_volume #3829

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix(ibm_is_instance) : fixed force new on change in snapshot in boot_volume #3829

merged 1 commit into from
Jun 21, 2022

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Jun 7, 2022 •
edited
Loading

Relates OR Closes #3819

Output from acceptance testing:

=== RUN   TestAccIBMISInstanceSnapshotRestore_forcenew
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISInstanceSnapshotRestore_forcenew (657.48s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     659.240s

--- PASS: TestAccIBMISInstanceSnapshotRestore_basic (356.79s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     358.436s

--- PASS: TestAccIBMISInstance_rip (216.26s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     217.620s

--- PASS: TestAccIBMISInstance_basic (338.99s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     340.842s

@hkantare
Copy link
Collaborator

Please add the testcases results and make documentation change to remove Force new

@uibm uibm force-pushed the boot-snapshot-forcenew branch from 255fe23 to 9791349 Compare June 15, 2022 08:34
@hkantare
Copy link
Collaborator

Please add the testcases results

@uibm uibm force-pushed the boot-snapshot-forcenew branch from b5933d8 to df2445b Compare June 20, 2022 11:43
@hkantare
Copy link
Collaborator

Can you add the normal basic instance test cases

@hkantare hkantare merged commit b77c823 into IBM-Cloud:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ibm_is_instance should not not suppress change and force new on boot_volume.0.snapshot change
2 participants
@uibm @hkantare