instance profile patch enhancement

[deepaksibm]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[deepaksibm]

Closes #3784

[deepaksibm]

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstance_profile'
=== RUN   TestAccIBMISInstance_profile
no message sent
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISInstance_profile (321.67s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     323.978s

[deepaksibm]

Works as expected - with changes in the profiles (non disk to disk or vice versa) result in destruction of older and creation of newer instance.

for profile with disk -> profile = "mx2d-2x16"

$ terraform apply --auto-approve
ibm_is_ssh_key.example: Refreshing state... [id=r010-5674ab26-0a44-4a04-a11c-ddcc242c091a]
ibm_is_instance.example: Refreshing state... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2]
ibm_is_instance.example: Destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2]
ibm_is_instance.example: Still destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2, 10s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2, 20s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2, 30s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2, 40s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2, 50s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_1c1f897a-e9d6-4adc-975f-3af311af91e2, 1m0s elapsed]
ibm_is_instance.example: Destruction complete after 1m10s
ibm_is_instance.example: Creating...
ibm_is_instance.example: Still creating... [10s elapsed]
ibm_is_instance.example: Still creating... [20s elapsed]
ibm_is_instance.example: Still creating... [30s elapsed]
ibm_is_instance.example: Creation complete after 40s [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943]

Apply complete! Resources: 1 added, 0 changed, 1 destroyed.

Updated Instance Profile without disk -> profile = "mx2-2x16"

$ terraform apply --auto-approve
ibm_is_ssh_key.example: Refreshing state... [id=r010-5674ab26-0a44-4a04-a11c-ddcc242c091a]
ibm_is_instance.example: Refreshing state... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943]
ibm_is_instance.example: Destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 10s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 20s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 30s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 40s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 50s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 1m0s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 1m10s elapsed]
ibm_is_instance.example: Still destroying... [id=02b7_7de246cd-5ddc-430f-9a1d-6f35554f4943, 1m20s elapsed]
ibm_is_instance.example: Destruction complete after 1m24s
ibm_is_instance.example: Creating...
ibm_is_instance.example: Still creating... [10s elapsed]
ibm_is_instance.example: Still creating... [20s elapsed]
ibm_is_instance.example: Still creating... [30s elapsed]
ibm_is_instance.example: Creation complete after 39s [id=02b7_6ee1d836-2f60-43d9-9b43-f6f4a4ce7098]

Apply complete! Resources: 1 added, 0 changed, 1 destroyed.