-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tekton provider): Update tekton provider #3933
Conversation
ae626dd
to
4132e20
Compare
ibm/service/cdtektonpipeline/resource_ibm_cd_tekton_pipeline.go
Outdated
Show resolved
Hide resolved
ibm/service/cdtektonpipeline/resource_ibm_cd_tekton_pipeline.go
Outdated
Show resolved
Hide resolved
38e79a3
to
6f1b782
Compare
Moving this back to draft for now. We have more changes identified that we'd like to add to this before moving forward |
|
TODO
|
@hkantare we are close to completing this piece of work. I'm wondering about the process to get this change (once approved) out into a provider release. Can you point me to a doc that describes this process? |
90e9db3
to
1c979ce
Compare
TODO: update continuous-delivery-go-sdk version once the new build is available |
@hkantare I've marked the PR ready for review again. Let me know if you have any feedback, thanks |
* Update CD Tekton provider * Update tekton provider * Add tekton diff suppress functions * chore(tekton provider): bump tekton go sdk version to latest * chore(tekton provider): update secrets baseline * fix(tekton pipeline):fix pipeline_definition error * chore(tekton provider): fix optional property for trigger * chore(review): revert changes in provider.go * chore(review): revert provider.go changes * chore(code review): fix pipeline_id in doc * chore(code review): tekton provider string updates * chore(code review): doc fix * chore(code review): add missing provider updates * fix(tekton): schema, string and doc updates * chore(tekton): minor clean up * fix(tekton): fix trigger worker props * fix(tekton): json merge patch schema * fix(tekton): refactor enum property types * fix(tekton): snake case secret types * fix(tekton): refactor enum value * fix(tekton): support other settings on creation * fix(tekton): remove enabled flag * chore(tekton): remove duplicate trigger * fix(tekton): refactor trigger resource * chore(tekton): fix merge issue * chore(tekton): update secrets baseline * chore(tekton): format files * chore(tekton): format provider.go * chore(tekton): update to 0.1.0 Go SDK * fix(tekton): fix tekton test
* Update CD Tekton provider * Update tekton provider * Add tekton diff suppress functions * chore(tekton provider): bump tekton go sdk version to latest * chore(tekton provider): update secrets baseline * fix(tekton pipeline):fix pipeline_definition error * chore(tekton provider): fix optional property for trigger * chore(review): revert changes in provider.go * chore(review): revert provider.go changes * chore(code review): fix pipeline_id in doc * chore(code review): tekton provider string updates * chore(code review): doc fix * chore(code review): add missing provider updates * fix(tekton): schema, string and doc updates * chore(tekton): minor clean up * fix(tekton): fix trigger worker props * fix(tekton): json merge patch schema * fix(tekton): refactor enum property types * fix(tekton): snake case secret types * fix(tekton): refactor enum value * fix(tekton): support other settings on creation * fix(tekton): remove enabled flag * chore(tekton): remove duplicate trigger * fix(tekton): refactor trigger resource * chore(tekton): fix merge issue * chore(tekton): update secrets baseline * chore(tekton): format files * chore(tekton): format provider.go * chore(tekton): update to 0.1.0 Go SDK * fix(tekton): fix tekton test
Community Note
Changes
Update the tekton pipeline provider with latest go sdk:
github.com/IBM/continuous-delivery-go-sdk
tov0.0.8
tekton_pipeline_*
tocd_tekton_pipeline_*
ForceNew
to a few schemas where necessary for immutable valueshref
property to pipeline run resourcecreated
property tocreated_at
concurrency
object property tomax_concurrent_runs
integer propertypreview
worker option in v2 APIs, when supported in that region. Falls back topublic
if not supportedhtml_url
toruns_url
andrun_url
, for pipeline and pipelineRun resources respectivelytext
,single_select
,integration
,secure
,appconfig
token_matches
,digest_matches
,internal_validation
enable_slack_notifications
andenable_partial_cloning
pipeline settingsdefault
option in favour ofvalue
insteadOutput from acceptance testing:
Remaining work