Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CBR rule API type support #3971

Merged
merged 2 commits into from
Aug 18, 2022
Merged

add CBR rule API type support #3971

merged 2 commits into from
Aug 18, 2022

Conversation

soohoowoohoo
Copy link
Contributor

Signed-off-by: Stephen SooHoo soohoos@us.ibm.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMCbrRule'

=== RUN   TestAccIBMCbrRuleDataSourceBasic
--- PASS: TestAccIBMCbrRuleDataSourceBasic (17.29s)
=== RUN   TestAccIBMCbrRuleDataSourceAllArgs
--- PASS: TestAccIBMCbrRuleDataSourceAllArgs (14.97s)
=== RUN   TestAccIBMCbrRuleBasic
--- PASS: TestAccIBMCbrRuleBasic (13.62s)
=== RUN   TestAccIBMCbrRuleAllArgs
--- PASS: TestAccIBMCbrRuleAllArgs (25.24s)
PASS

@soohoowoohoo
add CBR rule API type support
854d3f8 
Signed-off-by: Stephen SooHoo <soohoos@us.ibm.com>
hkantare
hkantare reviewed Aug 16, 2022
View reviewed changes
ibm/service/contextbasedrestrictions/resource_ibm_cbr_zone.go
@@ -110,36 +115,6 @@ func ResourceIBMCbrZone() *schema.Resource {
Optional: true,
Description: "The IP address.",
},
"ref": &schema.Schema{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this "ref" been removed from schema?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CBR API only allowed to include "ref" in addresses object, other than excluded object.

@hkantare
Copy link
Collaborator

Can you fix the conflicts

@hkantare hkantare merged commit cd95bf7 into IBM-Cloud:master Aug 18, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@soohoowoohoo @zhenwan @SunithaGudisagarIBM1
add CBR rule API type support (IBM-Cloud#3971)
04acae1 
Signed-off-by: Stephen SooHoo <soohoos@us.ibm.com>

Signed-off-by: Stephen SooHoo <soohoos@us.ibm.com>
Co-authored-by: Zhennan Wang <zhennan@us.ibm.com>
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@soohoowoohoo @zhenwan @SunithaGudisagarIBM1
add CBR rule API type support (IBM-Cloud#3971)
56a3c14 
Signed-off-by: Stephen SooHoo <soohoos@us.ibm.com>

Signed-off-by: Stephen SooHoo <soohoos@us.ibm.com>
Co-authored-by: Zhennan Wang <zhennan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

@zhenwan zhenwan zhenwan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soohoowoohoo @hkantare @zhenwan