CIS Firewall Rules : added priority key #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpit-srivastava-ibm
changed the title
|
Test case - |
|
The test cases and documentation already covered creation and updation of resource with |
hkantare
reviewed
Sep 2, 2022
| @@ -181,7 +185,8 @@ func ResourceIBMCISFirewallrulesUpdate(context context.Context, d *schema.Resour | |||
| if d.HasChange(cisFilterID) || | |||
| d.HasChange(cisFirewallrulesAction) || | |||
| d.HasChange(cisFirewallrulesPaused) || | |||
| d.HasChange(cisFilterDescription) { | |||
| d.HasChange(cisFilterDescription) || | |||
| d.HasChange(cisFirewallrulesPriority) { | |||
|
|
|||
There was a problem hiding this comment.
in update handle the support for change in priority
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* added priority to firewallrules * revert conflict changes * added priority in update Co-authored-by: Arpit Srivastava <arpit-mac@Arpits-MacBook-Pro.local>
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* added priority to firewallrules * revert conflict changes * added priority in update Co-authored-by: Arpit Srivastava <arpit-mac@Arpits-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement -
priorityfield in Firewall Rules while creating or updating a resourceIssue - https://github.ibm.com/NetworkTribe/CIS_Support/issues/2515