Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for new ciphers #4018

Merged
merged 2 commits into from
Sep 27, 2022
Merged

added support for new ciphers #4018

merged 2 commits into from
Sep 27, 2022

Conversation

deepaksibm
Copy link
Contributor

validate method correction

updated test case

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@deepaksibm
Copy link
Contributor Author 


$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISIKEPolicy_basic'
=== RUN   TestAccIBMISIKEPolicy_basic
--- PASS: TestAccIBMISIKEPolicy_basic (63.45s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     65.178s

@deepaksibm deepaksibm marked this pull request as draft September 8, 2022 05:51
@deepaksibm
added support for new ciphers
30c0bf8 
validate method correction

updated test case
@deepaksibm
vpc sdk upgrade
7d51a70
@deepaksibm deepaksibm marked this pull request as ready for review September 26, 2022 07:09
@hkantare hkantare merged commit 4c4b193 into IBM-Cloud:master Sep 27, 2022
hkantare pushed a commit that referenced this pull request Oct 3, 2022
@deepaksibm @hkantare
added support for new ciphers (#4018)
00bb520 
* added support for new ciphers

validate method correction

updated test case

* vpc sdk upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepaksibm @hkantare