feat: implement resource and data sources to create and fetch direct link route reports #4065

ajay-malhotra1 · 2022-09-27T01:26:23Z

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDLRouteReportDataSource_basic'
=== RUN   TestAccIBMDLRouteReportDataSource_basic
--- PASS: TestAccIBMDLRouteReportDataSource_basic (309.57s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/directlink	310.318s
...

$ make testacc TESTARGS='-run=TestAccIBMDLRouteReportResource_basic'
=== RUN   TestAccIBMDLRouteReportResource_basic
--- PASS: TestAccIBMDLRouteReportResource_basic (281.03s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/directlink	281.729s
...

$ make testacc TESTARGS='-run=TestAccIBMDLRouteReportsDataSource_basic'
=== RUN   TestAccIBMDLRouteReportsDataSource_basic
--- PASS: TestAccIBMDLRouteReportsDataSource_basic (356.05s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/directlink	356.788s
...

kavya498 · 2022-10-10T05:47:53Z

ibm/service/directlink/data_source_ibm_dl_gateway.go

@@ -75,6 +75,46 @@ func DataSourceIBMDLGateway() *schema.Resource {
 				},
 			},

+			dlAsPrepends: {
+				Type:        schema.TypeList,
+				Optional:    true,


All the inner attributes are computed, parent attribute should be marked as computed..

kavya498 · 2022-10-10T05:48:49Z

ibm/service/directlink/data_source_ibm_dl_gateways.go

+						dlAsPrepends: {
+							Type:        schema.TypeList,
+							Optional:    true,
+							ForceNew:    false,


All the inner attributes are computed, parent attribute should be marked as computed..

kavya498 · 2022-10-10T05:54:45Z

ibm/service/directlink/data_source_ibm_dl_route_report.go

+
+	getGatewayRouteReportOptionsModel := &directlinkv1.GetGatewayRouteReportOptions{GatewayID: &gatewayId, ID: &routeReportId}
+	report, response, err := directLink.GetGatewayRouteReport(getGatewayRouteReportOptionsModel)
+	if err != nil {


check if report == nil as well along with err !=nil
if err != nil && report == nil {

Since you are setting id only when report is not nil not returning error while report == nil will result in unusual terraform behaviour

Added the nil check for report separately below to return a different error

kavya498 · 2022-10-10T05:57:39Z

ibm/service/directlink/data_source_ibm_dl_route_reports_test.go

+		gateway = ibm_dl_gateway.test_dl_gateway.id
+	 }
+
+	 data "ibm_dl_route_reports" "test_dl_reports" {


This datasource will execute before ibm_dl_route_report is actually created
Add depends_on on ibm_dl_route_reports datasource for actual functunality testing

This datasource is referencing the resource ibm_dl_route_report now and will be called after that route report resource creation.

kavya498 · 2022-10-10T06:03:01Z

ibm/service/directlink/resource_ibm_dl_route_report.go

+	gatewayId := d.Get(dlGatewayId).(string)
+	createGatewayRouteReportOptionsModel := &directlinkv1.CreateGatewayRouteReportOptions{GatewayID: &gatewayId}
+	routeReport, response, err := directLink.CreateGatewayRouteReport(createGatewayRouteReportOptionsModel)
+	if err != nil {


check for routeReport == nil along with err !=nil

Added the nil check for routeReport separately below to return a different error

kavya498 · 2022-10-10T06:04:16Z

ibm/service/directlink/resource_ibm_dl_route_report.go

+	getGatewayRouteReportOptionsModel := &directlinkv1.GetGatewayRouteReportOptions{GatewayID: &gatewayId, ID: &routeReportId}
+	report, response, err := directLink.GetGatewayRouteReport(getGatewayRouteReportOptionsModel)
+	if err != nil {
+		log.Println("[WARN] Error fetching DL Route Reports", response, err)


check for response status == 404.. if 404 setId to "". This helps in lifecycle management.
Refer other resources for reference

kavya498 · 2022-10-10T06:06:56Z

metadata/provider_metadata.json

@@ -17554,6 +17554,257 @@
                }
            }
        ],
+        "ibm_dl_route_report": [


This file is auto-generated during release.. Kindly remove changes from this file

kavya498 · 2022-10-10T06:11:00Z

website/docs/r/dl_route_report.html.markdown

+}
+```
+
+## Argument reference


Please make sure argument reference matches with resource schema.
Any Required / Optional / Optional and Computed arguments in the schema should be mentioned in Argument reference section

Any argument that is marked as only computed in schema should be mentioned in Attribute reference..

All

kavya498 · 2022-10-10T06:13:16Z

website/docs/r/dl_route_report.html.markdown

+    - `virtual_connection_type` - (String) Virtual Connection type
+
+## Import
+The `ibm_dl_gateway` resource can be imported by using gateway ID. 


Import is possible with the id that is set for d.SetId in the create method of the resource..

Id is set to a combination in the resource

d.SetId(fmt.Sprintf("%s/%s", gatewayId, *routeReport.ID))

Resource can be imported using <gateway_ID>/<report_ID>. Please update the docs accordingly.

kavya498 · 2022-10-10T06:14:07Z

website/docs/r/dl_route_report.html.markdown

+layout: "ibm"
+page_title: "IBM : dl_route_report"
+description: |-
+  Manages IBM Direct Link Gateway.


Kindly change to appropriate description of the resource

kavya498

Kindly address review comments, rebase and resolve conflicts
Thanks

ajay-malhotra1 · 2022-10-11T02:07:12Z

@kavya498 The review comments have been addressed. Can you please review it again

…ort resource

…atasource

ajay-malhotra1 added 4 commits September 26, 2022 18:20

feat: implement resource and data sources for direct link route report

a69371f

Merge remote-tracking branch 'upstream/master' into rr

4bfbd9c

chore: update the example for route report resource

12eacde

chore: removed logs which are not needed

926d9e2

kavya498 reviewed Oct 10, 2022

View reviewed changes

kavya498 requested changes Oct 10, 2022

View reviewed changes

ajay-malhotra1 added 2 commits October 10, 2022 18:43

addressed review comments

80ea2da

addressed review comments

f162deb

ajay-malhotra1 added 8 commits October 10, 2022 22:51

addressed review comments

dc6dd9f

Merge remote-tracking branch 'upstream/master' into rr

360a5e5

return nil in case the returned response code is 404 for dl route rep…

49023e0

…ort resource

added the documentation for AS Prepends for directlink resource and d…

b003034

…atasource

added the documentation for AS Prepends for directlink resource and d…

b5c1d0c

…atasource

added the documentation for AS Prepends for directlink resource and d…

339ec4b

…atasource

added the documentation for AS Prepends for directlink resource and d…

e130a42

…atasource

added the documentation for AS Prepends for directlink resource and d…

14ebabb

…atasource

hkantare merged commit 3253ad1 into IBM-Cloud:master Oct 14, 2022

ajay-malhotra1 deleted the rr branch October 14, 2022 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement resource and data sources to create and fetch direct link route reports #4065

feat: implement resource and data sources to create and fetch direct link route reports #4065

ajay-malhotra1 commented Sep 27, 2022 •

edited

Loading

kavya498 Oct 10, 2022

kavya498 Oct 10, 2022

kavya498 Oct 10, 2022

ajay-malhotra1 Oct 11, 2022

kavya498 Oct 10, 2022

ajay-malhotra1 Oct 11, 2022

kavya498 Oct 10, 2022

ajay-malhotra1 Oct 11, 2022

kavya498 Oct 10, 2022

kavya498 Oct 10, 2022

kavya498 Oct 10, 2022

kavya498 Oct 10, 2022

kavya498 Oct 10, 2022

kavya498 left a comment

ajay-malhotra1 commented Oct 11, 2022

feat: implement resource and data sources to create and fetch direct link route reports #4065

feat: implement resource and data sources to create and fetch direct link route reports #4065

Conversation

ajay-malhotra1 commented Sep 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kavya498 left a comment

Choose a reason for hiding this comment

ajay-malhotra1 commented Oct 11, 2022

ajay-malhotra1 commented Sep 27, 2022 •

edited

Loading