Disable/Enable Rotation Policy support for kms key

[harshit777]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[harshit777]

Reference to this PR, #4071, its a replication of the same, had to close it because many of conflicts, creating this one with the same changes.

[dinesh-venkatraman-g]

Add evidences of all test cases passing without any failures

[Sidd-kp]

LGTM!! Great work. Well done cleaning up the other test suits as well.

[harshit777]

=== RUN TestAccIBMKMSDataSourceKeyPolicy_basicNew
--- PASS: TestAccIBMKMSDataSourceKeyPolicy_basicNew (74.93s)
=== RUN TestAccIBMKMSKeyRingDataSource_basic
--- PASS: TestAccIBMKMSKeyRingDataSource_basic (58.46s)
=== RUN TestAccIBMKMSKeyDataSource_basic
--- PASS: TestAccIBMKMSKeyDataSource_basic (65.46s)
=== RUN TestAccIBMKMSKeyDataSource_Key
--- PASS: TestAccIBMKMSKeyDataSource_Key (74.49s)
=== RUN TestAccIBMKMSKeyDataSourceHPCS_basic
data_source_ibm_kms_key_test.go:57:
--- SKIP: TestAccIBMKMSKeyDataSourceHPCS_basic (0.00s)
=== RUN TestAccIBMKmsDataSourceKeyPolicy_basic
--- PASS: TestAccIBMKmsDataSourceKeyPolicy_basic (69.19s)
=== RUN TestAccIBMKMSDataSource_basic
--- PASS: TestAccIBMKMSDataSource_basic (64.17s)
=== RUN TestAccIBMKMSKeyDataSource_Keys
--- PASS: TestAccIBMKMSKeyDataSource_Keys (73.55s)
=== RUN TestAccIBMKmsDataSourceKeysPolicy_basic
--- PASS: TestAccIBMKmsDataSourceKeysPolicy_basic (70.80s)
=== RUN TestAccIBMKpDataSource_basic
--- PASS: TestAccIBMKpDataSource_basic (54.59s)
=== RUN TestAccIBMKMSResource_Key_Alias_Name
--- PASS: TestAccIBMKMSResource_Key_Alias_Name (68.41s)
=== RUN TestAccIBMKMSResource_Key_Alias_Duplicate
--- PASS: TestAccIBMKMSResource_Key_Alias_Duplicate (49.13s)
=== RUN TestAccIBMKMSResource_Key_Alias_Key_Check
--- PASS: TestAccIBMKMSResource_Key_Alias_Key_Check (134.42s)
=== RUN TestAccIBMKMSResource_Key_Alias_Key_Limit
--- PASS: TestAccIBMKMSResource_Key_Alias_Key_Limit (50.06s)
=== RUN TestAccIBMKMSKeyPolicy_basic_check
--- PASS: TestAccIBMKMSKeyPolicy_basic_check (99.74s)
=== RUN TestAccIBMKMSKeyPolicy_basic_check_enable
--- PASS: TestAccIBMKMSKeyPolicy_basic_check_enable (115.20s)
=== RUN TestAccIBMKMSKeyPolicy_rotation_check
--- PASS: TestAccIBMKMSKeyPolicy_rotation_check (69.22s)
=== RUN TestAccIBMKMSKeyPolicy_dualAuth_check
--- PASS: TestAccIBMKMSKeyPolicy_dualAuth_check (71.26s)
=== RUN TestAccIBMKMSKeyPolicy_dualAuth_check_with_Alias
--- PASS: TestAccIBMKMSKeyPolicy_dualAuth_check_with_Alias (72.68s)
=== RUN TestAccIBMKMSResource_Key_Ring_Name
--- PASS: TestAccIBMKMSResource_Key_Ring_Name (55.14s)
=== RUN TestAccIBMKMSResource_Key_Ring_Key
--- PASS: TestAccIBMKMSResource_Key_Ring_Key (63.63s)
=== RUN TestAccIBMKMSResource_Key_Ring_Not_Exist
--- PASS: TestAccIBMKMSResource_Key_Ring_Not_Exist (38.56s)
=== RUN TestAccIBMKMSResource_basic
resource_ibm_kms_key_test.go:20:
--- SKIP: TestAccIBMKMSResource_basic (0.00s)
=== RUN TestAccIBMKMSHPCSResource_basic
resource_ibm_kms_key_test.go:55:
--- SKIP: TestAccIBMKMSHPCSResource_basic (0.00s)
=== RUN TestAccIBMKMSResource_ValidExpDate
--- PASS: TestAccIBMKMSResource_ValidExpDate (84.84s)
=== RUN TestAccIBMKMSResource_InvalidExpDate
--- PASS: TestAccIBMKMSResource_InvalidExpDate (46.32s)
=== RUN TestAccIBMKpResource_basic
--- PASS: TestAccIBMKpResource_basic (56.61s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kms 1682.588s

[harshit777]

List of successful scenarios

rotationInterval as 3

rotationInterval as 5 and disabled

rotationInterval as 3 and enabled

disable rotation policy

enable rotation policy

List of Failures

enable with invalid interval_month

disable with invalid interval_month

enable with no rotation policy

disable with no rotation policy

[dinesh-venkatraman-g]

• Can you also add a test case for updating enabled: false and interval_month: x
• Also, can you run all test case once, since there are changes in ibm_kms_key resource and data source?

[dinesh-venkatraman-g]

lgtm!!! Thanks @harshit777 for thorough testing and evidences.