Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for virtual endpoint gateway to be available after creation #4206

Merged
merged 1 commit into from
Dec 14, 2022
Merged

wait for virtual endpoint gateway to be available after creation #4206

merged 1 commit into from
Dec 14, 2022

Conversation

deepaksibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@deepaksibm
Copy link
Contributor Author 


$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVirtualEndpointGateway_Basic'
=== RUN   TestAccIBMISVirtualEndpointGateway_Basic
--- PASS: TestAccIBMISVirtualEndpointGateway_Basic (97.86s)
=== RUN   TestAccIBMISVirtualEndpointGateway_Basic_SecurityGroups
--- PASS: TestAccIBMISVirtualEndpointGateway_Basic_SecurityGroups (93.95s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     193.526s

@deepaksibm
Copy link
Contributor Author

Closes #2236

hkantare
hkantare reviewed Dec 1, 2022
View reviewed changes
ibm/service/vpc/resource_ibm_is_virtual_endpoint_gateway.go Outdated
@@ -307,6 +307,10 @@ func resourceIBMisVirtualEndpointGatewayCreate(d *schema.ResourceData, meta inte
}

d.SetId(*result.ID)
_, err = isWaitForVirtualEndpointGatewayAvailable(sess, d.Id(), d.Timeout(schema.TimeoutUpdate))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use schema.TimeoutCreate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/IBM-Cloud/terraform-provider-ibm/pull/4206/files#diff-a0d9b3493bb9618e40ba9b89e9cd9f93b54b8ba4de246bf6f6701cbfbbf72f53R62
Timeouts: &schema.ResourceTimeout is already defined

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we have used update we shd use create right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@hkantare hkantare merged commit 1d506ce into IBM-Cloud:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepaksibm @hkantare