Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume not found error while destroying ibm_pi_volume resource #4252

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix volume not found error while destroying ibm_pi_volume resource #4252

merged 2 commits into from
Dec 20, 2022

Conversation

dhirendersingh19
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

=== RUN   TestAccIBMPIVolumebasic
--- PASS: TestAccIBMPIVolumebasic (135.99s)
PASS
=== RUN   TestAccIBMPIVolumePool
--- PASS: TestAccIBMPIVolumePool (80.69s)
PASS
=== RUN   TestAccIBMPIVolumeGRS
--- PASS: TestAccIBMPIVolumeGRS (273.82s)
PASS
...

@dhirendersingh19 dhirendersingh19 added the service/Power Systems Issues related to Power Systems label Dec 20, 2022
@dhirendersingh19 dhirendersingh19 linked an issue Dec 20, 2022 that may be closed by this pull request
ibm_pi_volume_attach is deleting the volumes on destroy #4250
Closed
yussufsh
yussufsh approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkantare hkantare merged commit cc9e96f into IBM-Cloud:master Dec 20, 2022
@dhirendersingh19 dhirendersingh19 deleted the volume-delete-fix branch December 23, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoralesjr rmoralesjr rmoralesjr approved these changes

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@kavya498 kavya498 Awaiting requested review from kavya498

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ibm_pi_volume_attach is deleting the volumes on destroy
4 participants
@dhirendersingh19 @yussufsh @rmoralesjr @hkantare