Adding new resources to support BGP Route Filters in direct link gateway #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dified existing direct link gateway to add BGP Route filter
sushmitha1506
changed the title
added 2 commits
January 24, 2023 17:09
…dified existing direct link gateway to add BGP Route filter
…dified existing direct link gateway to add BGP Route filter
MalarvizhiK
reviewed
Mar 23, 2023
hkantare
reviewed
Apr 5, 2023
ibm/service/directlink/data_source_ibm_dl_export_route_filter.go
Outdated
Show resolved
Hide resolved
hkantare
approved these changes
Apr 10, 2023
| cisDomainSettingsSecurityHeaderPreload: { | ||
| Type: schema.TypeBool, | ||
| Description: "security header preload", | ||
| Required: true, |
There was a problem hiding this comment.
This will be breaking change we can't include Required directly mark it as optional
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
…way (IBM-Cloud#4294) * Added new data blocks to support Direct Link BGP Route filters and modified existing direct link gateway to add BGP Route filter * Added new data blocks to support Direct Link BGP Route filters and modified existing direct link gateway to add BGP Route filter * Added new data blocks to support Direct Link BGP Route filters and modified existing direct link gateway to add BGP Route filter * addressed reveiw comments * addressed review comments * Fixed review comments * addressed review comments * addressed review comments * addressed review comments --------- Co-authored-by: sushmitha M <sushmitham@sushmithas-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TC-After-Comments-Fix.pdf
Description of the Changes
As part of the addition of the BGP Route Filter to the direct link, do support the terraform to add the export/import filter to the direct link gateway.
As part of this implementation, we have modified the existing direct link gateway resource block used to create a direct link.
And added 4 new data blocks to read all export/import route filters and to read the given export/import filter.
And addressed the delta changes with respect to terraform and API Spec, As part of these changes, below attributes are added to the gateway creation resources ( ibm_dl_gateway )and respected data blocks.(ibm_dl_gateways & ibm_dl_gateway)
Reference API Spec
APISpec
Modified the resources
Modified the data blocks
New datasources
Output from acceptance testing:
Test Result
Sample_terrafrom.txt
TEstResult-BGPRouteFilters.pdf
TR-New-att-GW.pdf
Changes with respect to CIS
Added Preload option to Security Headers of Zone Settings for CIS.
"preload": Whether or not to permit browsers to preload security_header config.
CLI documentation for the same -https://cloud.ibm.com/docs/cli?topic=cli-cis-cli#update-domain-settings
Output from acceptance testing:
arpit-mac@Arpits-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/cis TESTARGS='-run=TestAccIBMCisSettings_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cis -v -run=TestAccIBMCisSettings_Basic -timeout 700m
=== RUN TestAccIBMCisSettings_Basic
--- PASS: TestAccIBMCisSettings_Basic (1.603s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cis 1.603s