Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object versioning and bucket replication fix #4355

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Object versioning and bucket replication fix #4355

merged 3 commits into from
Feb 28, 2023

Conversation

IBM-diksha
Copy link
Collaborator

--- PASS: TestAccIBMCOSBucketObject_Versioning_Enabled (28.20s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 29.700s

--- PASS: TestAccIBMCOSBucketObject_Versioning_Enabled_Sequential_Upload (31.11s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 32.475s

--- PASS: TestAccIBMCOSBucketObject_Overwriting (28.31s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 29.701s

@IBM-diksha
Copy link
Collaborator Author

Latest Acceptance tests:
=== RUN TestAccIBMCOSBucketObject_VersioningEnabled
--- PASS: TestAccIBMCOSBucketObject_VersioningEnabled (26.14s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 27.532s

=== RUN TestAccIBMCOSBucketObject_Versioning_Enabled_Sequential_Upload_on_Existing_Bucket
--- PASS: TestAccIBMCOSBucketObject_Versioning_Enabled_Sequential_Upload_on_Existing_Bucket (26.44s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 27.915s

=== RUN TestAccIBMCOSBucketObject_Uploading_Multile_Objects_on_Existing_Bucket_without_Versioning
--- PASS: TestAccIBMCOSBucketObject_Uploading_Multile_Objects_on_Existing_Bucket_without_Versioning (28.26s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 30.751s

hkantare
hkantare reviewed Feb 27, 2023
View reviewed changes
ibm/service/cos/resource_ibm_cos_replication_configuration.go
Description: "The Cloud Resource Name (CRN) of the bucket where you want COS to store the results",
Type: schema.TypeString,
Required: true,
Description: "The Cloud Resource Name (CRN) of the bucket where you want COS to store the results",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is validateFunc removed? can't we have crn for regex?

@hkantare hkantare merged commit 1d1acc9 into IBM-Cloud:master Feb 28, 2023
This was referenced Mar 10, 2023
Closed
Closed
IBM-diksha added a commit to IBM-diksha/terraform-provider-ibm that referenced this pull request Mar 17, 2023
@IBM-diksha
Object versioning and bucket replication fix (IBM-Cloud#4355)
0f48a94 
* Object versioning and bucket replication fix

* Updating the bucketcrn to use the variable.

* Updating the test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IBM-diksha @hkantare