Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to allow memory / processor updates to server instances in either shutdown or active state #4383

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix to allow memory / processor updates to server instances in either shutdown or active state #4383

merged 1 commit into from
Mar 8, 2023

Conversation

rachari
Copy link
Collaborator

@rachari rachari commented Mar 2, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (407.27s)
PASS

@rachari
Copy link
Collaborator Author

rachari commented Mar 2, 2023

@rmoralesjr @yussufsh Can you review this ?

yussufsh
yussufsh approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachari this lgtm
Can we have more tests where we perform the update flow?

@rmoralesjr rmoralesjr self-requested a review March 2, 2023 16:37
@rmoralesjr rmoralesjr requested a review from hkantare March 3, 2023 14:56
@kavya498 kavya498 merged commit d028bbe into IBM-Cloud:master Mar 8, 2023
@rachari rachari mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoralesjr rmoralesjr rmoralesjr approved these changes

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachari @yussufsh @rmoralesjr @kavya498