feat: Catalog Management enhancements #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test, fix object test
feat: Catalog management enhancements
|
General comment |
|
@hkantare ok, I added the required attribute back and marked it as deprecated as it says to do in the docs you linked. |
|
@hkantare please review again, would love for this to make it in the beta release so BNPP can use it and give feedback. |
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
* docs: small doc fix for validation resource * fix: don't store auto generated tags in tf state * fix: first pass at getting solution_info working * deprecation support for offerings and versions * support usage data, deprecation fixes * feat: publish changes, validation enhancements * fix: document conflict fixes with mutex, typo and computed value changes * fix: deprecate_pending computed only and doc updates * feat: support configuration values on a version * fix: make configuration computed and optional so include_config works * fix: idempotent argument issues * fix: add config mode so configurations can be cleared * docs: updates to version resource docs * fix: add tags and keywords to offering read function, add new version test, fix object test * feat: add terraform version to version resource, update version resource docs * docs: Update offering resource docs * fix: show configurations config constraints in tf state * fix: mark removed required attribute as deprecated --------- Co-authored-by: Ben Buchanan <buchanan@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #4216
Closes #4331
Closes #4332
Closes #4372
Closes #4373
Closes #4374
Output from acceptance testing (I ran a script that runs all CM tests, and removed unrelated lines from the output to fit the character limit of this PR):
Show test results
Test Results