Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex used for validating a secret group name #4451

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Fix regex used for validating a secret group name #4451

merged 2 commits into from
Mar 30, 2023

Conversation

IdanAdar
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@IdanAdar IdanAdar requested review from haimsch and hkantare and removed request for haimsch March 30, 2023 13:48
@kavya498 kavya498 merged commit f2cc64c into master Mar 30, 2023
@IdanAdar IdanAdar changed the title Fix regex used for validating a secrer group name Fix regex used for validating a secret group name Mar 30, 2023
@kavya498 kavya498 deleted the sm-fix-regex-check branch March 30, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavya498 kavya498 kavya498 approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IdanAdar @kavya498