pDNS documention correction for CR forwarding rule. #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheltons
reviewed
Jul 19, 2023
| @@ -74,7 +74,7 @@ Review the argument reference that you can specify for your resource. | |||
| * `resolver_id` - (Required, String) The unique identifier of a custom resolver. | |||
| * `description` - (Optional, String) Descriptive text of the forwarding rule. | |||
| * `type` - (Optional, String) Type of the forwarding rule. | |||
| * Constraints: Allowable values are: `zone`, `hostname`,`Default`. | |||
| * Constraints: Allowable values is: `zone`. | |||
There was a problem hiding this comment.
This should be
Constraints: Allowable value is:
zone.
There was a problem hiding this comment.
You mean it should not be in single quote. Is it so?
There was a problem hiding this comment.
Changed it @sheltons . Please approve it now.
There was a problem hiding this comment.
The quotes are fine. It's the agreement between singular "Allowable value is" or plural "Allowable values are".
sheltons
reviewed
Jul 20, 2023
| @@ -74,7 +74,7 @@ Review the argument reference that you can specify for your resource. | |||
| * `resolver_id` - (Required, String) The unique identifier of a custom resolver. | |||
| * `description` - (Optional, String) Descriptive text of the forwarding rule. | |||
| * `type` - (Optional, String) Type of the forwarding rule. | |||
| * Constraints: Allowable values are: `zone`, `hostname`,`Default`. | |||
| * Constraints: Allowable values is: zone. | |||
There was a problem hiding this comment.
Please add the quotes back in, and change "values" to "value".
- Constraints: Allowable value is:
zone.
There was a problem hiding this comment.
I think, It got merged. I'll do it with new request. :) .
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
* Enabled argument updated in docs for PDNS glb resource * reverting the change made to main branch wrongly * Document correction for CR forwarding rule type * Corrected documentation for forwarding rule type value
benbuchanan
pushed a commit
to benbuchanan/terraform-provider-ibm
that referenced
this pull request
Aug 17, 2023
* Enabled argument updated in docs for PDNS glb resource * reverting the change made to main branch wrongly * Document correction for CR forwarding rule type * Corrected documentation for forwarding rule type value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
It has been observe, we need to correct our documentation for CR forwarding rule resources. CR forwarding rule type should be zone only while hostname is wrongly mentioned in valid options for type.
This PR is to correct the documentation for pDNS.