Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CIS - remove deafult value for min_tls_version #4947

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: CIS - remove deafult value for min_tls_version #4947

merged 1 commit into from
Nov 23, 2023

Conversation

arpit-srivastava-ibm
Copy link
Contributor

Issue - #4937

Test Cases -

arpit-mac@Arpits-MacBook-Pro-6 terraform-provider-ibm % make testacc TEST=./ibm/service/cis TESTARGS='-run=TestAccIBMCisSettings_Basic'   

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cis -v -run=TestAccIBMCisSettings_Basic -timeout 700m
--- PASS: TestAccIBMCisSettings_Basic (675.20s)
PASS
ok 	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cis	676.840s

arpit-mac@Arpits-MacBook-Pro-6 terraform-provider-ibm % make testacc TEST=./ibm/service/cis TESTARGS='-run=TestAccIBMCisTLSSettings_Basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cis -v -run=TestAccIBMCisTLSSettings_Basic -timeout 700m
--- PASS: TestAccIBMCisTLSSettings_Basic (350.01s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cis	351.567s

@hkantare hkantare merged commit a23e7e7 into IBM-Cloud:master Nov 23, 2023
2 checks passed
@arpit-srivastava-ibm arpit-srivastava-ibm mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpit-srivastava-ibm @hkantare