Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-13603-fix attachment terraform #4952

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

archanaponnada
Copy link
Contributor

@archanaponnada archanaponnada commented Nov 27, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Issue :
In ibm_scc_profile_attachment, notification is made mandatory which is incorrect

Fix :
In ibm_scc_profile_attachment, notification is made optional.
Screenshot 2023-11-27 at 2 19 09 PM

Screenshot 2023-11-27 at 2 19 24 PM

How will it work :

  1. Now notification is optional, ie when notification is not given also system will accept.
  2. If notification object is given and enabled=false, it will ignore controls object - we need to fix at code level.Tracked under issue#13603
  3. If notification object is given and controls object id given - it will be ignore - we need to fix at code level.Tracked under issue#13603
    Output from acceptance testing:
Screenshot 2023-11-27 at 2 30 43 PM

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hkantare hkantare merged commit ea4c07b into IBM-Cloud:master Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants