-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Cloud connection refactor data source and documentation #5053
Refactor Cloud connection refactor data source and documentation #5053
Conversation
@Diptipowervs please run and paste the test results here. |
--- PASS: TestAccIBMPICloudConnectionDataSource_basic (153.76s) |
- `region` - `lon` | ||
- `zone` - `lon04` | ||
|
||
Example usage: | ||
|
||
Example usage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is part of the second bullet point—no need to remove a tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data "ibm_pi_cloud_connection" "example" { | ||
pi_cloud_connection_name = "%s" | ||
pi_cloud_instance_id = "%s" | ||
}`, acc.PiCloudConnectionName, acc.Pi_cloud_instance_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a new line, this part of the same line. The line number is the same, but view is squished so it appears to be on a new line.
@ismirlia lgtm, but would like your review as well. |
Co-authored-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
Co-authored-by: Yussuf Shaikh <yussuf.shaikh1@ibm.com>
--- PASS: TestAccIBMPICloudConnectionDataSource_basic (30.26s) |
Community Note
Relates OR Closes #0000
Output from acceptance testing: