Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): Add operator support to subject_attributes in Authorziation Policy #5076

Merged

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Jan 26, 2024

Summary

Updated authorization policy to support operator in subject_attributes as well as wildcard support. Updated other minor failing tests.

Note: leaving as draft until go sdk PR IBM/platform-services-go-sdk#297 is merged. Then I can update this PR with go.mod and go.sum changes.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes IAM issue #2140

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMIAMAuthorizationPolicy'
...
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	160.876s
...
$ make testacc TESTARGS='-run=TestAccIBMIAMAccessGroupPolicy'
...
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	846.155s
...
$ make testacc TESTARGS='-run=TestAccIBMIAMUserPolicy'
...
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	534.823s

Ran user policy test for sanity check to make sure there was no impact from any other changes.

…s in Authorziation Policy

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@swcolley
Copy link
Contributor Author

Tests after latest commit:

$ make testacc TESTARGS='-run=TestAccIBMIAMAccessGroupPolicy'
...
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	489.073s
...
$ make testacc TESTARGS='-run=TestAccIBMIAMAuthorizationPolicy'
...
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	140.749s
...
$ make testacc TESTARGS='-run=TestAccIBMIAMUserPolicy'
...
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	352.565s

@swcolley swcolley marked this pull request as ready for review January 29, 2024 15:07
@hkantare
Copy link
Collaborator

hkantare commented Jan 30, 2024

@swcolley fix the conflicts in files

@hkantare hkantare merged commit abb4292 into IBM-Cloud:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants