Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detach volumes in docs #5128

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Add detach volumes in docs #5128

merged 5 commits into from
Mar 4, 2024

Conversation

Diptipowervs
Copy link
Contributor

This in response to: powervs-ibm#57

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Feb 21, 2024
yussufsh
yussufsh approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

michaelkad
michaelkad reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for a volume

website/docs/r/pi_volume_attach.html.markdown Outdated Show resolved Hide resolved
@Diptipowervs @michaelkad
Update website/docs/r/pi_volume_attach.html.markdown
b13071c 
Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
@hkantare hkantare merged commit 846cff3 into IBM-Cloud:master Mar 4, 2024
1 check passed
@michaelkad michaelkad deleted the attach-detach branch May 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia left review comments

@michaelkad michaelkad michaelkad approved these changes

@yussufsh yussufsh yussufsh approved these changes

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Diptipowervs @yussufsh @michaelkad @ismirlia @hkantare