Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate(is-lb-listener-redirect): Deprecate lb listener https redirect flattened structure #5140

Merged
merged 4 commits into from
Feb 16, 2024
Merged

deprecate(is-lb-listener-redirect): Deprecate lb listener https redirect flattened structure #5140

merged 4 commits into from
Feb 16, 2024

Conversation

deepaksibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@deepaksibm
deprecate(is-lb-listener-redirect): Deprecate lb listener https redir…
ece1427 
…ect arguments and add support for target list

policy updates

doc update

update and doc changes

lb listener changes

removed unwanted code

schema changes
@deepaksibm
test changes
8631c11
@deepaksibm
test correction
7957eeb
@deepaksibm
doc update
137dae5
@deepaksibm
Copy link
Contributor Author 

tfpt TestAccIBMISLBListenerPolicyHttpRedirectNew_basic
=== RUN   TestAccIBMISLBListenerPolicyHttpRedirectNew_basic
--- PASS: TestAccIBMISLBListenerPolicyHttpRedirectNew_basic (1926.76s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1929.179s


tfpt TestAccIBMISLBListenerPolicyHttpRedirect_basic
=== RUN   TestAccIBMISLBListenerPolicyHttpRedirect_basic
--- PASS: TestAccIBMISLBListenerPolicyHttpRedirect_basic (1559.08s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1561.254s

tfpt TestAccIBMISLBListenerHttpRedirectNew_basic
=== RUN   TestAccIBMISLBListenerHttpRedirectNew_basic
--- PASS: TestAccIBMISLBListenerHttpRedirectNew_basic (1364.45s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1366.866s

tfpt TestAccIBMISLBListenerHttpRedirect_basic
=== RUN   TestAccIBMISLBListenerHttpRedirect_basic
--- PASS: TestAccIBMISLBListenerHttpRedirect_basic (1312.97s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1315.629s

@deepaksibm
Copy link
Contributor Author

Closes #5087

@hkantare hkantare merged commit c4141e4 into IBM-Cloud:master Feb 16, 2024
1 check passed
@deepaksibm deepaksibm deleted the deprecate-https-redirect branch February 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepaksibm @hkantare