Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated vpc-go-sdk to 0.49.1 version #5223

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Mar 20, 2024

Community Note

Breaking changes from sdk:

  • ibm/service/vpc/data_source_ibm_is_snapshot_consistency_group.go name changed in vpc-go-sdk
  • ibm/service/vpc/resource_ibm_is_snapshot_consistency_group.go same as above
  • ibm/service/vpc/resource_ibm_is_snapshot_consistency_group_test.go test file changes
  • ibm/service/vpc/resource_ibm_is_vpn_gateway_connections.go, ibm/service/vpc/resource_ibm_is_vpn_gateway_connection_test.go added logic and test cases for converting based on the type
vpnGatewayConnection := vpnGatewayConnectionIntf.(*vpcv1.VPNGatewayConnection)
  • ibm/service/vpc/data_source_ibm_is_vpn_gateway_connections.go added logic for converting based on the type
vpnGatewayConnection := vpnGatewayConnectionIntf.(*vpcv1.VPNGatewayConnection)
  • ibm/service/vpc/data_source_ibm_is_vpn_gateway_connection.goadded logic for converting based on the type
vpnGatewayConnection := vpnGatewayConnectionIntf.(*vpcv1.VPNGatewayConnection)
$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVPNGatewayConnection_multiple'
=== RUN   TestAccIBMISVPNGatewayConnection_multiple
--- PASS: TestAccIBMISVPNGatewayConnection_multiple (488.40s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     490.947s
$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsVPNGatewayConnectionDataSourceBasic
=== RUN   TestAccIBMIsVPNGatewayConnectionDataSourceBasic
--- PASS: TestAccIBMIsVPNGatewayConnectionDataSourceBasic (690.06s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     692.420s
$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVpnGatewayConnectionsDataSource_basic'
=== RUN   TestAccIBMISVpnGatewayConnectionsDataSource_basic
--- PASS: TestAccIBMISVpnGatewayConnectionsDataSource_basic (619.97s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     622.261s
$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsSnapshotConsistencyGroupBasic'
=== RUN   TestAccIBMIsSnapshotConsistencyGroupBasic
--- PASS: TestAccIBMIsSnapshotConsistencyGroupBasic (335.21s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     337.432s
$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsSnapshotConsistencyGroupDataSourceBasic'
=== RUN   TestAccIBMIsSnapshotConsistencyGroupDataSourceBasic
--- PASS: TestAccIBMIsSnapshotConsistencyGroupDataSourceBasic (232.78s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     234.408s
$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsSnapshotConsistencyGroupsDataSourceBasic'
=== RUN   TestAccIBMIsSnapshotConsistencyGroupsDataSourceBasic
--- PASS: TestAccIBMIsSnapshotConsistencyGroupsDataSourceBasic (267.60s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     269.245s

@ujjwal-ibm ujjwal-ibm force-pushed the migration-vpc-go-sdk49 branch from 796ab10 to 8e980c3 Compare March 22, 2024 05:23
@hkantare hkantare merged commit d85cd00 into IBM-Cloud:master Mar 22, 2024
1 check passed
@ujjwal-ibm ujjwal-ibm deleted the migration-vpc-go-sdk49 branch March 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants