Change network type from list to set in resource instance #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ismirlia changes look good but can you please post some test results here? |
|
I think there might be an issue with how this works currently, I'm going to mark it as draft for now. |
The previous solution replaced the list with a set to allow terraform to ignore changes in the order of networks during a read, but if networks were to get added via something like ibmcloud_pi_network_port_attach then this currently triggers the forcenew. This doesn't make sense because a user is allowed to attach networks or volumes without having to create a new instance.
|
Similarly you can take a instance in and out of a placement-group. |
|
Acceptance Test |
ismirlia
added a commit
to powervs-ibm/terraform-provider-ibm
that referenced
this pull request
Apr 11, 2024
…5253) * Change network type from list to set * Replace forcenew with diffsuppressfunc The previous solution replaced the list with a set to allow terraform to ignore changes in the order of networks during a read, but if networks were to get added via something like ibmcloud_pi_network_port_attach then this currently triggers the forcenew. This doesn't make sense because a user is allowed to attach networks or volumes without having to create a new instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue where doing terraform apply after an instance has been created will cause it to show that there were changes in the configuration even though there weren't.
This PR is fixes: #5224