Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasource] [Resource] Power Network Peers #5835

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Datasource] [Resource] Power Network Peers #5835

merged 1 commit into from
Dec 4, 2024

Conversation

Alexander-Kita
Copy link
Collaborator

Add [D]: pi_network_peers
Update [D]: pi_network, pi_networks
Update [R]: pi_network

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkPeerOnPrem
--- PASS: TestAccIBMPINetworkPeerOnPrem (43.32s)
PASS

=== RUN   TestAccIBMPINetworksDataSource_basic
--- PASS: TestAccIBMPINetworksDataSource_basic (16.10s)
PASS

=== RUN   TestAccIBMPINetworkPeersDataSourceBasic
--- PASS: TestAccIBMPINetworkPeersDataSourceBasic (15.47s)
PASS

...

@michaelkad
Network Peers
b11c128 
Add [D]: pi_network_peers
Update [D]: pi_network, pi_networks
Update [R]: pi_network
Add require option

Add v1.9.0

fix spacing in cst file
@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Dec 3, 2024
@Alexander-Kita Alexander-Kita mentioned this pull request Dec 3, 2024
Closed
@yussufsh yussufsh merged commit d5d150f into IBM-Cloud:master Dec 4, 2024
1 check passed
@yussufsh yussufsh deleted the network-peer branch December 4, 2024 11:40
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Dec 4, 2024
@Alexander-Kita @michaelkad @ismirlia
Network Peers (IBM-Cloud#5835)
c13a21e 
Add [D]: pi_network_peers
Update [D]: pi_network, pi_networks
Update [R]: pi_network
Add require option

Add v1.9.0

fix spacing in cst file

Co-authored-by: michaelkad <michaelkadiayi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@michaelkad michaelkad Awaiting requested review from michaelkad

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @yussufsh @michaelkad