This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
feat: improve swagger basepath handling #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunniclm
approved these changes
Jul 24, 2017
Codecov Report
@@ Coverage Diff @@
## develop #269 +/- ##
===========================================
+ Coverage 90.02% 90.04% +0.02%
===========================================
Files 11 11
Lines 1243 1246 +3
===========================================
+ Hits 1119 1122 +3
Misses 124 124
Continue to review full report at Codecov.
|
tunniclm
added a commit
that referenced
this pull request
Aug 31, 2017
Release 2.8.0 ### Bug Fixes * default toolchain type clone ([e0bb80d](e0bb80d)) * override default toolchain type ([4f8b681](4f8b681)) * **package:** update generator-ibm-cloud-enablement to version 0.0.57 ([#284](#284)) ([fb308fc](fb308fc)) ### Features * decouple path reformatting from swaggerize ([349cec4](349cec4)) * improve swagger basepath handling ([#269](#269)) ([810ba5e](810ba5e)) * intial kubernetes support ([8df16e6](8df16e6)) * intial kubernetes support ([b6a259c](b6a259c)) * kubernetes helm support ([d1ab81a](d1ab81a)) * kubernetes helm support ([692ed5f](692ed5f)) * kubernetes support ([25341ea](25341ea)) * kubernetes support ([4227a7a](4227a7a)) * kubernetes support ([d1b7b49](d1b7b49)) * kubernetes support ([694a263](694a263))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If swagger basePath is found, create a basePath variable and add the the value from the swagger. Withing the route handling code, the basePath variable is concatenated to the remaining part of the route that was specified in the swagger. This makes the code easier to read, especially if the basepath is very long. In the case where no basepath is specified, the variable is not created.