This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
fix: default toolchain type link #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #280 +/- ##
===========================================
+ Coverage 90.04% 90.05% +<.01%
===========================================
Files 11 11
Lines 1246 1247 +1
===========================================
+ Hits 1122 1123 +1
Misses 124 124
Continue to review full report at Codecov.
|
|
@tunniclm - All CI checks have passed. |
christiancompton
changed the title
tunniclm
approved these changes
Aug 21, 2017
|
@tunniclm I thought about your suggestion to have a validation method where repoType needed to match one of the valid options. While this would be beneficial, most users will never have this field directly in their spec. Even if a user provided an extraneous value, the toolchain.yml is still interpreted without error - |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses this [GHE issue], which requests that the
toolchain.ymldefault totype: clonefor all interactions, with the exception of using thebx dev enablecommand, where it should betype: link. That requite change has been made in the appropriate starter kit & cloud-enablement.