This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunniclm
approved these changes
Aug 25, 2017
lgtm, assuming tests pass. I see a bunch of version updates in dependencies here, usually I put dependency version upgrades out into their own PR so they can be dealt with separately (unless the version upgrade is required for the other code changes). I think Greenkeeper may already have created some of these automatically. |
Codecov Report
@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
+ Coverage 90.01% 90.05% +0.03%
===========================================
Files 11 11
Lines 1252 1257 +5
===========================================
+ Hits 1127 1132 +5
Misses 125 125
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support of Kubernetes deployment, including Helm files, by leveraging https://github.com/ibm-developer/generator-ibm-cloud-enablement