This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
chore: remove configuration dependency #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Lees11
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #417 +/- ##
========================================
Coverage 90.61% 90.61%
========================================
Files 9 9
Lines 1278 1278
========================================
Hits 1158 1158
Misses 120 120Continue to review full report at Codecov.
|
tunniclm
approved these changes
Jan 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed configuration from the default package.swift file for the generator as part of issue #526.
This should have no impact on the code since configuration is brought in by CloudEnvironment anyway.
Was run tested with npm run coverage and although one test failed this test was already failing on develop so considering it to be passing tests.