This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
feat: Add ElephantSQL #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EnriqueL8
commented
May 24, 2018
EnriqueL8
commented
- Add ElephantSQL
- Fix fatal crash when not providing credential for Postgres
christiancompton
approved these changes
May 24, 2018
|
Looks good @EnriqueL8 - add the 1.2.0 release of service-enablement, update/rebase on develop, and merge 👍 |
Codecov Report
@@ Coverage Diff @@
## develop #546 +/- ##
==========================================
- Coverage 90.7% 90.7% -0.01%
==========================================
Files 9 9
Lines 1345 1366 +21
==========================================
+ Hits 1220 1239 +19
- Misses 125 127 +2
Continue to review full report at Codecov.
|
test/lib/common_test.js
Outdated
| var mapping = 'elephant_sql' | ||
| var label = 'elephantsql' | ||
| var plan = servicePlan || helpers.getBluemixDefaultPlan('elephantsql') | ||
| var sourceFile = 'ServiceElephantsql.swift' |
There was a problem hiding this comment.
'ServiceElephantSql.swift' - service-enablement camelcases the laters after the -.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.