FEAT: RoCE and Hipersocket support for LPAR Cluster #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: K Shiva Sai <shiva.sai.k1@ibm.com>
|
Hi @AmadeusPodvratnik , Code changes looks good to me. since changes are there in all.yaml and host_vars can you please take a glance over there. |
AmadeusPodvratnik
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Hi @k-shiva-sai thank you for the PR. In general the code looks good but pls see my comments (minor).
Signed-off-by: K Shiva Sai <shiva.sai.k1@ibm.com>
Signed-off-by: K Shiva Sai <shiva.sai.k1@ibm.com>
AmadeusPodvratnik
approved these changes
Oct 15, 2024
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the Roce and Hipersocket for LPAR Cluster
Introduced one new variable to all.yaml and two new variables to the host_vars_template
In all.yaml
internal_ipwhich need to defined when bringing up the cluster with hipersocket cards.In host_vars
modetells the network card mode like osa/roce/hipersocketinternal_ipneeds to be defined when mode is hipersocket