Skip to content

Commit

Permalink
Issue 1590 (#1591)
Browse files Browse the repository at this point in the history
* feat: power vs v2 enhancements

* fix: vpn servers

* fix
  • Loading branch information
jvallexm authored and GitHub Enterprise committed Feb 28, 2024
1 parent e3d0c93 commit b5a83d9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ All notable changes to this project will be documented in this file.

### Fixes

- Fixed an issue causing the VPN Server page to crash when opening the creation modal

## 1.12.0

Expand Down
4 changes: 3 additions & 1 deletion client/src/lib/docs/release-notes.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
{
"version": "1.12.1",
"features": ["Users can now use the `Trial` plan for secrets manager"],
"fixes": [],
"fixes": [
"Fixed an issue causing the VPN Server page to crash when opening the creation modal"
],
"upgrade_notes": []
},
{
Expand Down
2 changes: 1 addition & 1 deletion client/src/lib/state/vpn-servers.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ function initVpnState(store) {
invalidText: selectInvalidText("protocol"),
groups: ["TCP", "UDP"],
onRender: function (stateData) {
return stateData.protocol.toUpperCase();
return (stateData.protocol || "").toUpperCase();
},
onInputChange: function (stateData) {
return stateData.protocol.toLowerCase();
Expand Down
7 changes: 7 additions & 0 deletions unit-tests/state/vpn-servers.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,13 @@ describe("vpn_servers", () => {
"it should render correctly"
);
});
it("should return protocol null on render", () => {
assert.deepEqual(
craig.vpn_servers.protocol.onRender({}),
"",
"it should render correctly"
);
});
describe("vpnServersWorkspaceHelperText", () => {
it("should return correct helper text", () => {
assert.deepEqual(
Expand Down

0 comments on commit b5a83d9

Please sign in to comment.