Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable metrics-collector for IBM Cloud Logs #144

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Enable metrics-collector for IBM Cloud Logs #144

merged 1 commit into from
Dec 16, 2024

Conversation

reggeenr
Copy link
Collaborator

This PR provides

  • a README update that describes how to setup the metrics collector dashboard in IBM Cloud Logs
  • adjusts the default interval of the metrics-collector and sets 30 seconds
  • adjusts error handling while observing the disk space to ignore EOF related exceptions

qu1queee
qu1queee approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qu1queee qu1queee merged commit 37a6677 into main Dec 16, 2024
2 checks passed
@qu1queee qu1queee deleted the metrics-collector-icl-enablement branch December 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reggeenr @qu1queee