Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search index not updating properly when a versioned reference is updated to a different versioned reference #3446

Closed
kmbarton423 opened this issue Mar 9, 2022 · 3 comments
Assignees
Labels
bug Something isn't working P1 Priority 1 - Must Have

Comments

@kmbarton423
Copy link
Contributor

Created a Patient, deleted it, then created it again (current version is 3)
Created a Condition with subject set to Patient/<patient.resource.id>/_history/1
Did a search for this Condition with _include of the subject:
.../Condition?_id=<condition.resource.id>&_include=Condition:subject
Received the expected response of the Condition along with Patient/<patient.resource.id>/_history/1
Updated the Condition subject to Patient/<patient.resource.id>/_history/2
Repeated the search above
Expected to receive only the Condition resource since the subject versioned reference is a deleted Patient.
Instead, received the previous search response of the Condition along with Patient/<patient.resource.id>/1

Working on the latest version of main.

@kmbarton423 kmbarton423 added bug Something isn't working P1 Priority 1 - Must Have labels Mar 9, 2022
@kmbarton423
Copy link
Contributor Author

Per discussion with Robin ... added label, estimate, and release

@punktilious punktilious self-assigned this Mar 14, 2022
@punktilious
Copy link
Collaborator

It appears as though the reference version field is not included in the fingerprint and so the parameter update is being skipped because the ingestion code thinks that nothing has changed.

punktilious added a commit that referenced this issue Mar 14, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Mar 14, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Mar 14, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Mar 14, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Mar 15, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre added a commit that referenced this issue Mar 18, 2022
Issue #3446 reference version missing from parameter hash
@tbieste
Copy link
Contributor

tbieste commented Mar 21, 2022

I verified that the behavior described in this issue is now working as expected.
In this case, while testing, after updating the Condition to point to (deleted) version 2 of the Patient, the Patient is no longer returned as "included", which matches the expected behavior.
Marking as closed.

@tbieste tbieste closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Priority 1 - Must Have
Projects
None yet
Development

No branches or pull requests

3 participants